From 2b8287dca8e7800b1d2f467b239f42b94998eb7b Mon Sep 17 00:00:00 2001
From: reo101 <pavel.atanasov2001@gmail.com>
Date: Sun, 15 Sep 2024 15:43:09 +0300
Subject: [PATCH] chore(jeeves)!: update `samba` config

Now (as of last `nix flake update`) using more structured `Nix`
---
 hosts/nixos/jeeves/samba.nix | 54 +++++++++++++++++++-----------------
 1 file changed, 28 insertions(+), 26 deletions(-)

diff --git a/hosts/nixos/jeeves/samba.nix b/hosts/nixos/jeeves/samba.nix
index 4f1ae52..a0f68b6 100644
--- a/hosts/nixos/jeeves/samba.nix
+++ b/hosts/nixos/jeeves/samba.nix
@@ -15,33 +15,35 @@
     enable = true;
     package = pkgs.sambaFull;
     openFirewall = true;
-    securityType = "user";
-    extraConfig = ''
-      # Files
-      workgroup = WORKGROUP
-      server string = Jeeves
-      netbios name = jeeves
-      security = user
-      #use sendfile = yes
-      #max protocol = smb2
-      # NOTE: localhost is the ipv6 localhost ::1
-      hosts allow = 192.168.0. 192.168.1. 10.100.0. 127.0.0.1 localhost
-      hosts deny = 0.0.0.0/0
-      guest account = nobody
-      map to guest = bad user
+    settings = {
+      global = {
+        # Files
+        "workgroup" = "WORKGROUP";
+        "server string" = "Jeeves";
+        "netbios name" = "jeeves";
+        "security" = "user";
+        # "use sendfile" = "yes";
+        # "max protocol" = "smb2";
+        # NOTE: localhost is the ipv6 localhost ::1
+        # TODO: keep glogal network metadata somehow
+        "hosts allow" = "192.168.0. 192.168.1. 10.100.0. 127.0.0.1 localhost";
+        "hosts deny" = "0.0.0.0/0";
+        "guest account" = "nobody";
+        "map to guest" = "bad user";
 
-      # Symlinks
-      allow insecure wide links = yes
+        # Symlinks;
+        "allow insecure wide links" = "yes";
 
-      # Printers
-      load printers = yes
-      printing = cups
-      printcap name = cups
-    '';
-    shares = {
+        # Printers;
+        "load printers" = "yes";
+        "printing" = "cups";
+        "printcap name" = "cups";
+      };
+
+      # Shares
       public = {
-        path = "/data/samba/public";
-        browseable = "yes";
+        "path" = "/data/samba/public";
+        "browseable" = "yes";
         "read only" = "no";
         "guest ok" = "yes";
         "create mask" = "0644";
@@ -50,8 +52,8 @@
         "force group" = "users";
       };
       private = {
-        path = "/data/samba/private";
-        browseable = "yes";
+        "path" = "/data/samba/private";
+        "browseable" = "yes";
         "read only" = "no";
         "guest ok" = "no";
         "create mask" = "0644";